Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

Update LICENSE #13

Closed
wants to merge 1 commit into from
Closed

Update LICENSE #13

wants to merge 1 commit into from

Conversation

ogaston
Copy link

@ogaston ogaston commented Jan 12, 2019

No description provided.

keywordnew
keywordnew approved these changes Jan 12, 2019
View reviewed changes
Copy link
Contributor

@keywordnew keywordnew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

I'm not sure we need to update or include the dates anymore.

@WaleedAshraf
Copy link

@mhdawson because of the merge?

@MylesBorins
Copy link

MylesBorins commented Jan 16, 2019 •
edited
Loading

@WaleedAshraf nodejs/TSC#195 (comment)

The Board Foundation Subcommittee met last month and the board discussed this issue in our last meeting. Here's the summary of the discussion. The net of the conversation is that the copyright notice is not critical but the best practices were boiled down to the following:

  • Do not strip or alter existing copyright notices.
  • Other projects have utilized “[Foundation Name or Project Name] and its contributors”.
  • Adding dates is not preferable. It does not have a legal impact and would be excluded only for ease of administration.
  • If a file is updated by the project past the original author, one may add the project copyright notice.
  • SPDX tagging (https://spdx.org/) can be helpful for scanning when adding new files

MylesBorins
MylesBorins suggested changes Jan 16, 2019
View reviewed changes
Copy link

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the conversation in nodejs/TSC#195 (comment) I don't think we should be changing the license header. For new license we can avoid the date... but it doesn't have legal reasons to change it

WaleedAshraf
WaleedAshraf suggested changes Jan 16, 2019
View reviewed changes
Copy link

@WaleedAshraf WaleedAshraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ogaston Anyways, thanks for the first contribution try. 👍keep going.

keywordnew
keywordnew reviewed Jan 16, 2019
View reviewed changes
Copy link
Contributor

@keywordnew keywordnew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @ogaston! 👍🏽

Because of the legal requirements outlined in the comments above, we'll refrain from changing the license date. Future licenses will not be including a date anymore and old licenses with a date will be allowed to remain that way.

I'll be closing this pull request without merging. Please do continue to build on your new familiarity with the Node.js project by continuing to contribute in issues and PRs! 🧡

Glad to have you onboard!

@keywordnew keywordnew closed this Jan 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@keywordnew keywordnew keywordnew approved these changes

@WaleedAshraf WaleedAshraf WaleedAshraf requested changes

@MylesBorins MylesBorins MylesBorins requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ogaston @mhdawson @WaleedAshraf @MylesBorins @keywordnew